Open
Conversation
tildeee
reviewed
May 29, 2018
| }) | ||
| .catch((error) => { | ||
| console.log(error.response); | ||
| if (error.response.data && error.response.data.errors) { |
There was a problem hiding this comment.
the indentation here started to confuse me a little! small comment
tildeee
reviewed
May 29, 2018
| const tripDescription = $('#description'); | ||
| tripDescription.empty(); | ||
| const tripCategory = $('#category'); | ||
| tripName.empty(); |
There was a problem hiding this comment.
You probably meant tripCategory.empty(); here? also below you have another copy/paste of tripName
TREKWhat We're Looking For
Good work! The code looks good and your styling looks great (even though you mentioned CSS is a weird challenge, you did a good job with this!) Everything worked really well in general. Great job |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TREK
Congratulations! You're submitting your assignment!
Comprehension Questions