Gen 5 searcher tabs header change from "Advances" to "Target Advance"#508
Open
NickPlayeZ wants to merge 3 commits intoAdmiral-Fish:masterfrom
Open
Gen 5 searcher tabs header change from "Advances" to "Target Advance"#508NickPlayeZ wants to merge 3 commits intoAdmiral-Fish:masterfrom
NickPlayeZ wants to merge 3 commits intoAdmiral-Fish:masterfrom
Conversation
Changed many of the "Advances" column headers in ONLY the searcher tabs of gen 5 windows to "Target Advance" as that is a more fitting descriptor that has confused quite a lot of newcomers to gen 5 rng in the past. Also changed the gen 5 IDs Initial Advances to Starting Advance for the same reason; a more fitting descriptor. IV Advances and all Dream Radar Advances stayed as they are as those start at 0 and therefore just "Advances" is perfectly accurate.
Changed many of the "Advances" column headers in ONLY the searcher tabs of gen 5 windows to "Target Advance" as that is a more fitting descriptor that has confused quite a lot of newcomers to gen 5 rng in the past. Also changed the gen 5 IDs Initial Advances to Starting Advance for the same reason; a more fitting descriptor. IV Advances and all Dream Radar Advances stayed as they are as those start at 0 and therefore just "Advances" is perfectly accurate.
Owner
|
Is this actually useful to do? Other gens have searchers as well and lead to inconsistencies within the program. |
Contributor
Author
|
Yes very useful; making the program more understandable to newcomers is in my opinion more important than just being consistent within the same program. Other generations also work differently in parts so it wouldn't make sense to change it for all gens (though I haven't thought about what other gens and their methods it may make sense for). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed many of the "Advances" column headers in ONLY the searcher tabs of gen 5 windows to "Target Advance" as that is a more fitting descriptor that has confused quite a lot of newcomers to gen 5 rng in the past. Also changed the gen 5 IDs Initial Advances to Starting Advance for the same reason; a more fitting descriptor. IV Advances and all Dream Radar Advances stayed as they are as those start at 0 and therefore just "Advances" is perfectly accurate.