[configurationwebhooks] Code generation: update services and models#1643
[configurationwebhooks] Code generation: update services and models#1643AdyenAutomationBot wants to merge 1 commit intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates new functionality for handling mandate-related webhooks within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request, which appears to be auto-generated, introduces new services and models for configurationwebhooks. The changes are mostly about adding support for mandate notifications. My review has identified a couple of areas for improvement. Firstly, in mandate.ts, createdAt and updatedAt properties are typed as any, which compromises type safety. They should be typed as Date. Secondly, there's a recurring pattern in several new model files (mandateBankAccount.ts, mandateNotificationRequest.ts, uKLocalMandateAccountIdentification.ts) where required properties are not initialized in the constructor. This could lead to runtime errors and violates TypeScript's strict property initialization rules. I've left specific comments with more details.
| "accountHolder": MandatePartyIdentification; | ||
| "accountIdentification": UKLocalMandateAccountIdentification; |
There was a problem hiding this comment.
The properties accountHolder and accountIdentification are declared as required (non-optional) but are not initialized in the constructor. This can lead to runtime errors if an instance is created and these properties are not immediately populated. This appears to be a systemic issue in the generated code. If these properties are truly required by the API, the ObjectSerializer should validate their presence. If they can be absent, they should be marked as optional (?) to reflect that and to comply with TypeScript's strict property initialization.
| "data": MandateNotificationData; | ||
| /** | ||
| * The environment from which the webhook originated. Possible values: **test**, **live**. | ||
| */ | ||
| "environment": string; | ||
| /** | ||
| * When the event was queued. | ||
| */ | ||
| "timestamp"?: Date; | ||
| /** | ||
| * Type of webhook. | ||
| */ | ||
| "type": MandateNotificationRequest.TypeEnum; |
There was a problem hiding this comment.
The properties data, environment, and type are declared as required (non-optional) but are not initialized in the constructor. This can lead to runtime errors if an instance is created and these properties are not immediately populated. This appears to be a systemic issue in the generated code. If these properties are truly required by the API, the ObjectSerializer should validate their presence. If they can be absent, they should be marked as optional (?) to reflect that and to comply with TypeScript's strict property initialization.
| "accountNumber": string; | ||
| /** | ||
| * The 6-digit [sort code](https://en.wikipedia.org/wiki/Sort_code), without separators or whitespace. | ||
| */ | ||
| "sortCode": string; | ||
| /** | ||
| * **ukLocal** | ||
| */ | ||
| "type": UKLocalMandateAccountIdentification.TypeEnum; |
There was a problem hiding this comment.
The properties accountNumber, sortCode, and type are declared as required (non-optional) but are not initialized in the constructor. This can lead to runtime errors if an instance is created and these properties are not immediately populated. This appears to be a systemic issue in the generated code. If these properties are truly required by the API, the ObjectSerializer should validate their presence. If they can be absent, they should be marked as optional (?) to reflect that and to comply with TypeScript's strict property initialization.
| */ | ||
| "balanceAccountId"?: string; | ||
| "counterparty"?: MandateBankAccount | null; | ||
| "createdAt"?: any; |
There was a problem hiding this comment.
The type of createdAt is any, which is not type-safe. For better type safety and consistency with other timestamp fields (like timestamp in MandateNotificationRequest), this should be typed as Date. The same applies to updatedAt on line 36. You will also need to update the attributeTypeMap for both properties to use "type": "Date" and "format": "date-time" (see lines 58-59 and 88-89).
| "createdAt"?: any; | |
| "createdAt"?: Date; |
1 participant
This PR contains the automated changes for the
configurationwebhooksservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.