[configurationwebhooks] Code generation: update services and models#899
[configurationwebhooks] Code generation: update services and models#899AdyenAutomationBot wants to merge 1 commit intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is an automated update to the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request introduces several new PHP model classes for Adyen Configuration Webhooks, including Mandate, MandateBankAccount, MandateBankAccountAccountIdentification, MandateNotificationData, MandateNotificationRequest, MandatePartyIdentification, and UKLocalMandateAccountIdentification. Additionally, a minor documentation update was made to the settlementDelayDays property in PlatformPaymentConfiguration.php. The review comments highlight an improvement opportunity in the newly added Mandate.php model, where date/time properties such as createdAt and updatedAt are incorrectly typed as object in the openAPITypes array and their corresponding getter/setter method signatures. These should be updated to \DateTime for enhanced type safety and consistency.
| 'balanceAccountId' => 'string', | ||
| 'counterparty' => '\Adyen\Model\ConfigurationWebhooks\MandateBankAccount', | ||
| 'createdAt' => 'object', | ||
| 'id' => 'string', |
There was a problem hiding this comment.
The createdAt property is typed as object in openAPITypes. For date/time fields, it's best practice to use \DateTime for better type safety and consistency with how jsonSerialize and toArray handle \DateTime objects.
'createdAt' => '\DateTime',| 'paymentInstrumentId' => 'string', | ||
| 'status' => 'string', | ||
| 'type' => 'string', | ||
| 'updatedAt' => 'object' |
There was a problem hiding this comment.
Similar to createdAt, the updatedAt property is typed as object. It should be \DateTime for improved type safety and consistency.
'updatedAt' => '\DateTime'| */ | ||
| public function getCreatedAt() | ||
| { | ||
| return $this->container['createdAt']; |
There was a problem hiding this comment.
The return type hint for getCreatedAt() is object|null. Given that this represents a date/time, it should be \DateTime|null for type accuracy and consistency with how \DateTime objects are handled elsewhere in the class (e.g., in toArray).
public function getCreatedAt()
{
return $this->container['createdAt'];| /** | ||
| * Sets createdAt | ||
| * | ||
| * @param object|null $createdAt createdAt |
There was a problem hiding this comment.
The parameter type hint for setCreatedAt() is object|null. It should be \DateTime|null to ensure type safety when setting a date/time value.
public function setCreatedAt($createdAt)
{
$this->container['createdAt'] = $createdAt;| /** | ||
| * Gets updatedAt | ||
| * | ||
| * @return object|null |
There was a problem hiding this comment.
The return type hint for getUpdatedAt() is object|null. It should be \DateTime|null for type accuracy and consistency.
public function getUpdatedAt()
{
return $this->container['updatedAt'];| /** | ||
| * Sets updatedAt | ||
| * | ||
| * @param object|null $updatedAt updatedAt |
There was a problem hiding this comment.
The parameter type hint for setUpdatedAt() is object|null. It should be \DateTime|null to ensure type safety when setting a date/time value.
public function setUpdatedAt($updatedAt)
{
$this->container['updatedAt'] = $updatedAt;
|
1 participant
This PR contains the automated changes for the
configurationwebhooksservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.