Skip to content

Always direct backup even when volume is in-use #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
c-mart wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Always direct backup even when volume is in-use #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 4 additions & 37 deletions cinderback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,51 +555,18 @@ def backup_volume(self, volume, name=None, client=None):
# Use encoded original volume info as description
description = BackupInfo(volume)

if volume.status == 'in-use':
_LI('Volume online so this is a multi-step process')

# Force snapshot since volume it's in-use
snapshot = self._create_and_wait(
'Creating snapshot', client.volume_snapshots,
arguments=dict(
volume_id=volume.id, force=True, name='tmp ' + name,
description='Temporary snapshot for backup',
metadata=volume.metadata))

# Create temporary volume from snapshot
tmp_vol = self._create_and_wait(
'Creating temp volume from snapshot', client.volumes,
arguments=dict(
size=snapshot.size, snapshot_id=snapshot.id,
name='tmp '+name,
description='Temporary volume for backup',
metadata=volume.metadata), resources=(snapshot,))

# Backup temporary volume
backup = self._create_and_wait(
'Doing the actual backup', client.backups,
arguments=dict(
volume_id=tmp_vol.id, name=name, container=None,
description=str(description)),
resources=(snapshot, tmp_vol))

# Cleanup temporary resources
_LI('Deleting temporary volume and snapshot')
tmp_vol.delete()
snapshot.delete()

elif volume.status == 'available':
if volume.status in ['available', 'in-use']:
backup = self._create_and_wait(
'Creating direct backup', client.backups,
'Creating backup', client.backups,
arguments=dict(
volume_id=volume.id, name=name, container=None,
description=str(description)))
description=str(description), force=True))
return backup

else:
_LE("We don't backup volume because status is %s", volume.status)
raise UnexpectedStatus(what=volume)

return backup

def _is_auto_backup(self, backup):
"""Check if a backup was created by us."""
Expand Down