Custom File Name Option #65
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's great @aaquibnaved |
|
Can you please merge this. I need this feature |
|
@abhishekchhugani I forked this repository and added changes from this pull request. Additionally, I added the ability to overwrite the component with loading renderer and no renderer (error). This fork is here and has the ability to add from npm: https://github.com/cyntler/react-doc-viewer |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mattmogford
For a project I'm working on, it was quite useful to be able to override the filename of the file I'm displaying using React Doc Viewer (as most of the files I'd be getting from an S3 store and the names wouldn't be that user friendly).
I created this small PR to accept an additional fileName parameter to override the filename if you'd like.
Feel free to comment and/or suggest improvements to the PR. I've made it as minimal as possible.