Open
Conversation
7633dc9 to
d212ed6
Compare
4dawit
commented
Jan 13, 2026
Author
4dawit
left a comment
There was a problem hiding this comment.
I don't love is_enum and optional_inline_flattened, but I couldn't figure out another way to pass in the context otherwise (couldn't access IS_OPTION with field_ty like in optional.rs since enum isn't a field, also struggled with not panicking inline_flattened() on Option<T> if T is an enum). There might be other cases to be handled (serde un/tagged, etc), please feel free to give feedback or refactor.
3883d99 to
c5010bd
Compare
c5010bd to
c73f4b3
Compare
Author
|
Follow up: I rebased and see that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Closes #461
Checklist