Check #[ts(flatten)] at compile time instead of panicking during export#480
Draft
gustavo-shigueo wants to merge 4 commits intomainfrom
Draft
Check #[ts(flatten)] at compile time instead of panicking during export#480gustavo-shigueo wants to merge 4 commits intomainfrom
gustavo-shigueo wants to merge 4 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Hey @NyxCode, since
#[ts(flatten)]has been getting a lot of attention lately, I thought it might be worth taking a look at checking if using it in any given field is legal at compile time instead of assuming it is and panicking at runtime if the assumption was wrong.Now, this PR is a draft for a few reasons:
Dependenciesenough to be even mildly confident that I did any of this correctlyChanges
Added a
Flattenabletrait to store theinline_flattenedmethod. AllFlattenables must implementTSfor obvious reasons, but several types implementTSwithout implementingFlattenable, e.g.:String,i32,booletc. This means that, when#[ts(flatten)]emits<T as Flattenable>::inline_flattened(), the user gets a compiler error if their type is cannot be flattenedChecklist