some fixes for multihost #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
entrypoint.sh
Outdated
| # Configuring settings.ini | ||
| cat "$CTF_PATH/settings.tmpl.ini" \ | ||
| | sed "s/MYSQL_PORT/$MYSQL_PORT/g" \ | ||
| | sed "/^DB_HOST/ s/mysql/$MYSQL_HOST/" \ |
Owner
There was a problem hiding this comment.
I'd rather update settings.tmpl.ini and use the same syntax everywhere.
Also if we do that, I'd like to have a fallback on a default value for the linked case :)
Contributor
Author
There was a problem hiding this comment.
ah, i thought that file comes from the base image.
Owner
|
Thanks again ! But could I ask you to squash your commits? |
Contributor
Author
|
my first rebase of allready pushed commits. not perfect but ok i hope |
Owner
|
Thanks, it would be great if you can set |
Contributor
Author
|
in docker-compose.yml you mean? |
Owner
|
I meant in entrypoint.sh, but I don't know if it's a good idea in the end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.