modified renameworkspace event listener to reapply ignore workspace logic for hyprland/workspaces #4675
+18
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YWh0301
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for dynamic updates to Waybar's "ignore-workspaces" configuration when workspaces are renamed.
Problem:
Currently, the renameworkspace event listener does not re-evaluate whether the renamed workspace should be ignored based on the "ignore-workspaces" rules. This prevents dynamic workspace renaming from being used as a method to manage workspace visibility in Waybar.
Solution:
Update the event handler to check the new workspace name against the "ignore-workspaces" configuration after each rename operation. This ensures that workspace visibility is properly updated when names change dynamically.
Use Case:
This change enables scripting workflows where workspace visibility in Waybar can be controlled by dynamically renaming workspaces based on the "ignore-workspaces" rules.