Add maintenance counters/percents#41
Open
andrei-marinache wants to merge 18 commits intoAlexxIT:masterfrom
Open
Add maintenance counters/percents#41andrei-marinache wants to merge 18 commits intoAlexxIT:masterfrom
andrei-marinache wants to merge 18 commits intoAlexxIT:masterfrom
Conversation
Add all "alert" sensors (some are alarms, some are info) Make sensor icons optional (Info ones will be "ON" if the "info" alert is active) Remove "filtered" alerts Set global "Alerts" sensor to "on" only if Alarm type alerts are active
More debug logging Ignore maintenance percents if any of the value is not between 0-100 or 255 (255 probably means that it's unused - for example when filter is not installed)
- Abort if sum(maintenance counters) > sum(total products)*5 - Abort if any of the maintenance percents are > 100 (except 255 which menas unused)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add maintenance counters & maintenance percents
Add sensors (maintenance percents, counters, alarms, etc.) to separate file with options for icons/name/etc.
Move UUIDs to separate file
Refactor bluetooth ping / read / write
#39