-
Notifications
You must be signed in to change notification settings - Fork 62
Update tresnet.py #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
|
/help |
|
@CodiumAI-Agent /review |
PR Reviewer Guide 🔍(Review updated until commit 60814ee)Here are some key observations to aid the review process:
|
|
/improve |
|
Persistent review updated to latest commit 60814ee |
|
@CodiumAI-Agent /improve --pr_code_suggestions.commitable_code_suggestions=true |
| self.downsample = downsample | ||
| self.stride = stride | ||
| reduce_layer_planes = max(planes * self.expansion // 4, 64) | ||
| reduce_layer_planes = max(planes * self.expansion / 4, 64) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Use integer division to ensure proper dimensionality in layer calculations. [possible issue, importance: 8]
| reduce_layer_planes = max(planes * self.expansion / 4, 64) | |
| reduce_layer_planes = max(planes * self.expansion // 4, 64) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mrge found 1 issue across 1 file. View it in mrge.io
| self.downsample = downsample | ||
| self.stride = stride | ||
| reduce_layer_planes = max(planes * self.expansion // 4, 64) | ||
| reduce_layer_planes = max(planes * self.expansion / 4, 64) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed integer division (//) to floating-point division (/) which may result in non-integer values for neural network dimensions



No description provided.