DPL Analysis: as<T>(cfg) for adjusting the types of configurables in expressions#14276
Merged
ktf merged 1 commit intoAliceO2Group:devfrom May 19, 2025
Merged
DPL Analysis: as<T>(cfg) for adjusting the types of configurables in expressions#14276ktf merged 1 commit intoAliceO2Group:devfrom
as<T>(cfg) for adjusting the types of configurables in expressions#14276ktf merged 1 commit intoAliceO2Group:devfrom
Conversation
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As Gandiva does not handle conversions with unsigned integer types internally, it is not trivial to apply filters for some of the columns. This feature creates a workaround, for example the following code
will create a valid filter where
cvaluewill be properly updated and cast touint8_tfor comparison with the column of the same type, but it can be provided normally in configuration JSON as a simpleintunlike for theuint8_tconfigurable that will be parsed as a character by C++.