Skip to content

Conversation

@hehoon
Copy link
Collaborator

@hehoon hehoon commented Nov 30, 2025

I have JIRA issue created

  • branch and/or PR name(s) includes JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected
  • FLP integration tests were ran successful

Depends on:

  • Displays errors related to plotting:
    • When the backend responded with an error message
    • When the request was timed out due to bad connectivity
    • When plotting failed due to an error caused by JSROOT
  • The draw and drawObject functions in draw.js have been rewritten to support a failure callback method which returns the error from (re)drawing the JSROOT plot in its parameters.
  • The object view page now displays JSROOT plotting errors too (instead of displaying a white canvas)

hehoon and others added 11 commits December 1, 2025 13:58
…OGUI-1830/error-message-for-object-not-found-due-to-filters
…age lacks punctuation. In addition, only add a whitespace to the end of the message if it is lacking one
…OGUI-1829/display-backend-and-jsroot-errors-on-frontend
Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v5...v6)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 5 to 6.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@v5...v6)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@hehoon hehoon marked this pull request as ready for review December 2, 2025 14:04
@hehoon hehoon requested a review from graduta as a code owner December 2, 2025 14:04
@graduta graduta merged commit e66c01b into dev Dec 4, 2025
10 checks passed
@graduta graduta deleted the feature/QCG/OGUI-1829/display-backend-and-jsroot-errors-on-frontend branch December 4, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants