[pull] master from bitcoinj:master#104
Merged
pull[bot] merged 4 commits intoAll-Blockchains:masterfrom Mar 24, 2026
Merged
Conversation
Since these modules are using JSpecify annotations they should not be relying on a transitive dependency for JSpecify.
`PeerSocketHandler` does not use the `PeerAddress` for anything other than log and exception messages. For those purposes it can get the `PeerAddress` from the implementing subclasses. This makes it more clear that `PeerSocketHandler` doesn't use a socket address for networking purposes. It also opens the door to further refactoring that emphasizes `PeerSocketHandler`'s true role of serializing and deserializing messages.
…filtered block is dropped Remove the `!` from `currentFilteredBlock.provideTransaction(tx)`, return if true, and fall-through if false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )