[pull] master from bitcoinj:master#105
Merged
pull[bot] merged 11 commits intoAll-Blockchains:masterfrom Mar 25, 2026
Merged
Conversation
…b.test.integration.peer`, source path `main` These integration test support classes are not tests and do not use anything from JUnit. We created the `o.b.test.integration` package for integration tests with the intention of moving integration tests into this package hierarchy. Moving these support class to the `main` source path for `o.b.test.integration.peer` * helps eliminate a split-package issue (`o.b.testing` is owned by the core module) * allows the package-info to be defined in the `main` source path * allows further development of these classes to be more general purpose * allows these support classes to have their own tests Also adds package-info to the new package `o.b.test.integration.peer`.
`TestWithPeerGroup` is a base class for implementing other tests and does not contain any tests itself. Mark it as `abstract` for clarity.
This randomization does not prevent the "address already in use" errors we have been seeing. It only randomizes the value upon class loading, so it is not randomized between tests. Since it is not necessary or helpful we remove it.
Add accessor `lastReceivedFilter()` and use it.
Use JUnit 6's support for constructor injection of `@TempDir` to initialize `walletFile` in the constructor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )