[pull] master from bitcoinj:master#97
Merged
pull[bot] merged 17 commits intoAll-Blockchains:masterfrom Mar 17, 2026
Merged
Conversation
…lockStore, SPVBlockStore: annotate nullable fields and methods
It is more idiomatic to use `this.` in an overridden method and it avoids a reference to a nullable field.
Using `setChainHead()` breaks a non-null guarantee because it can throw, so we set it directly.
By handling the `FileNotFoundException` from creating the `RandomAccessFile` separately we are able to guarantee that `SPVBlockStore` will not be successfully constructed without `randomAccessFile` being initialized. This also guarantees in the second catch block that `randomAccessFile` is not null.
This will clear the block cache even if an IO error occurs.
…d` directly in constructor The `setChainHead()` and `setVerifiedChainHead()` methods are not necessary at object initialization time and declare exceptions that break compiler guarantees of initialization and non-nullability.
…st: make implicit nullability assumptions explicit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )