[pull] master from bitcoinj:master#99
Merged
pull[bot] merged 11 commits intoAll-Blockchains:masterfrom Mar 20, 2026
Merged
Conversation
…eed.ofMnemonic()` instead of private constructor This change also clarifies that in these cases we don't need a constructor that takes a binary seed.
…fEncrypted() Use them in `DeterministicKeyChain` and make the "internal use only" constructors private.
…emonic code Instead use `splitMnemonicCode()` directly in the factory methods.
…ecureRandom` Instead use `getEntropy()` directly in the `ofRandom()` factory method.
…)`, `seedFromMnemonic()` from constructor
…l mnemonic code Instead use `optionalSeedFromMnemonic()` and `seedFromMnemonic()` directly in the constructors and factory methods.
This internal factory takes an optional `creationTime` and will be used to replace the private constructor that takes entrophy.
…tropyInternal()` Move the checking and conversion functionalities of the entropy constructor to the `ofEntropyInternal()` factory, and remove the constructor that takes entrophy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )