Automatically load streams on accessor#79
Merged
bruno-f-cruz merged 15 commits intomainfrom Nov 9, 2025
Merged
Conversation
Closed
There was a problem hiding this comment.
Pull Request Overview
This PR implements automatic loading of data streams when accessed, controlled by a new implicit_loading context manager. By default, streams will auto-load when their data is accessed, eliminating the need to explicitly call load() in most cases. Users can disable this behavior when needed by using implicit_loading(False).
Key changes:
- Added
implicit_loadingcontext manager usingcontextvarsfor thread-safe state management - Modified data access to automatically trigger loading when implicit loading is enabled
- Refactored internal naming from
_hashmapto_data_stream_mappingfor clarity - Enhanced test coverage for implicit loading scenarios including error handling and nested collections
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/contraqctor/contract/base.py | Implements implicit loading mechanism with context manager and updates data access logic to auto-load streams |
| tests/test_contract/test_core.py | Adds comprehensive tests for implicit loading behavior in various scenarios including nested collections and error states |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…cs/contraqctor into feat-auto-load
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #78