Skip to content

Make filter optional#53

Open
OliverJAsh wants to merge 1 commit intoAlorel:masterfrom
OliverJAsh:patch-1
Open

Make filter optional#53
OliverJAsh wants to merge 1 commit intoAlorel:masterfrom
OliverJAsh:patch-1

Conversation

@OliverJAsh
Copy link

Fixes #52

@ci-reporter
Copy link

ci-reporter bot commented May 7, 2020

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Travis CI build is failing as of eb2a448. Here's the output:

npm test
> shrink-ray-current@4.1.2 test /home/travis/build/Alorel/shrink-ray
> nyc mocha --check-leaks --bail

/home/travis/build/Alorel/shrink-ray/node_modules/yargs/yargs.js:1163
      else throw err
           ^

Error: The module '/home/travis/build/Alorel/shrink-ray/node_modules/iltorb/build/bindings/iltorb.node'
was compiled against a different Node.js version using
NODE_MODULE_VERSION 79. This version of Node.js requires
NODE_MODULE_VERSION 83. Please try re-compiling or re-installing
the module (for instance, using `npm rebuild` or `npm install`).
    at Object.Module._extensions..node (internal/modules/cjs/loader.js:1226:18)
    at Module.load (internal/modules/cjs/loader.js:1040:32)
    at Function.Module._load (internal/modules/cjs/loader.js:929:14)
    at Module.require (internal/modules/cjs/loader.js:1080:19)
    at require (internal/modules/cjs/helpers.js:72:18)
    at Object.<anonymous> (/home/travis/build/Alorel/shrink-ray/node_modules/iltorb/index.js:10:40)
    at Module._compile (internal/modules/cjs/loader.js:1176:30)
    at Module.replacementCompile (/home/travis/build/Alorel/shrink-ray/node_modules/append-transform/index.js:60:13)
    at Module._extensions..js (internal/modules/cjs/loader.js:1196:10)
    at Object.<anonymous> (/home/travis/build/Alorel/shrink-ray/node_modules/append-transform/index.js:64:4)
    at Module.load (internal/modules/cjs/loader.js:1040:32)
    at Function.Module._load (internal/modules/cjs/loader.js:929:14)
    at Module.require (internal/modules/cjs/loader.js:1080:19)
    at require (internal/modules/cjs/helpers.js:72:18)
    at Object.<anonymous> (/home/travis/build/Alorel/shrink-ray/test/compression.js:7:16)
    at Module._compile (internal/modules/cjs/loader.js:1176:30)
    at Module.replacementCompile (/home/travis/build/Alorel/shrink-ray/node_modules/append-transform/index.js:60:13)
    at Module._extensions..js (internal/modules/cjs/loader.js:1196:10)
    at Object.<anonymous> (/home/travis/build/Alorel/shrink-ray/node_modules/append-transform/index.js:64:4)
    at Module.load (internal/modules/cjs/loader.js:1040:32)
    at Function.Module._load (internal/modules/cjs/loader.js:929:14)
    at Module.require (internal/modules/cjs/loader.js:1080:19)
    at require (internal/modules/cjs/helpers.js:72:18)
    at /home/travis/build/Alorel/shrink-ray/node_modules/mocha/lib/mocha.js:334:36
    at Array.forEach (<anonymous>)
    at Mocha.loadFiles (/home/travis/build/Alorel/shrink-ray/node_modules/mocha/lib/mocha.js:331:14)
    at Mocha.run (/home/travis/build/Alorel/shrink-ray/node_modules/mocha/lib/mocha.js:811:10)
    at Object.exports.singleRun (/home/travis/build/Alorel/shrink-ray/node_modules/mocha/lib/cli/run-helpers.js:108:16)
    at exports.runMocha (/home/travis/build/Alorel/shrink-ray/node_modules/mocha/lib/cli/run-helpers.js:142:13)
    at Object.exports.handler (/home/travis/build/Alorel/shrink-ray/node_modules/mocha/lib/cli/run.js:292:3)
    at Object.runCommand (/home/travis/build/Alorel/shrink-ray/node_modules/yargs/lib/command.js:242:26)
    at Object.parseArgs [as _parseArgs] (/home/travis/build/Alorel/shrink-ray/node_modules/yargs/yargs.js:1104:24)
    at Object.parse (/home/travis/build/Alorel/shrink-ray/node_modules/yargs/yargs.js:566:25)
    at Object.exports.main (/home/travis/build/Alorel/shrink-ray/node_modules/mocha/lib/cli/cli.js:68:6)
    at Object.<anonymous> (/home/travis/build/Alorel/shrink-ray/node_modules/mocha/bin/mocha:164:29)
    at Module._compile (internal/modules/cjs/loader.js:1176:30)
    at Module.replacementCompile (/home/travis/build/Alorel/shrink-ray/node_modules/append-transform/index.js:60:13)
    at Module._extensions..js (internal/modules/cjs/loader.js:1196:10)
    at Object.<anonymous> (/home/travis/build/Alorel/shrink-ray/node_modules/append-transform/index.js:64:4)
    at Module.load (internal/modules/cjs/loader.js:1040:32)
    at Function.Module._load (internal/modules/cjs/loader.js:929:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12)
    at internal/main/run_main_module.js:17:47
----------|---------|----------|---------|---------|-------------------
File      | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
----------|---------|----------|---------|---------|-------------------
All files |       0 |        0 |       0 |       0 |                   
----------|---------|----------|---------|---------|-------------------

=============================== Coverage summary ===============================
Statements   : Unknown% ( 0/0 )
Branches     : Unknown% ( 0/0 )
Functions    : Unknown% ( 0/0 )
Lines        : Unknown% ( 0/0 )
================================================================================

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!


This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

@Evertt
Copy link

Evertt commented Feb 17, 2021

Will this get fixed any time soon? 😇

@cooljeffro
Copy link

any chance this will get released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Types: ShrinkRayOptions.filter should be optional

3 participants