Skip to content
This repository was archived by the owner on Jul 6, 2019. It is now read-only.

remove else, and early return :D#75

Open
sergiors wants to merge 2 commits intoAnahkiasen:masterfrom
sergiors:master
Open

remove else, and early return :D#75
sergiors wants to merge 2 commits intoAnahkiasen:masterfrom
sergiors:master

Conversation

@sergiors
Copy link
Contributor

No description provided.

@tamakiii
Copy link
Contributor

@sergiors Test fail

@sergiors
Copy link
Contributor Author

curious, in my unit tests were.. i will check

~/h/underscore-php (master|✔) $ phpunit
PHPUnit 5.0.0 by Sebastian Bergmann and contributors.

...............................................................  63 / 199 ( 31%)
............................................................... 126 / 199 ( 63%)
............................................................... 189 / 199 ( 94%)
..........                                                      199 / 199 (100%)

Time: 1.36 seconds, Memory: 16.25Mb

OK (199 tests, 311 assertions)
~/h/underscore-php (master|✔) $ php -v
PHP 5.6.13 (cli) (built: Sep 21 2015 15:04:19)
Copyright (c) 1997-2015 The PHP Group
Zend Engine v2.6.0, Copyright (c) 1998-2015 Zend Technologies
    with XCache v3.2.0, Copyright (c) 2005-2014, by mOo
    with Zend OPcache v7.0.6-dev, Copyright (c) 1999-2015, by Zend Technologies
    with Xdebug v2.3.3, Copyright (c) 2002-2015, by Derick Rethans
    with XCache Cacher v3.2.0, Copyright (c) 2005-2014, by mOo

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants