Open
Conversation
| ) = false | ||
|
|
||
| override fun onSwiped(viewHolder: RecyclerView.ViewHolder, direction: Int) { | ||
| val position = viewHolder.adapterPosition |
There was a problem hiding this comment.
При использовании DiffUtil и анимаций adapterPosition может возвращать NO_POSITION или некорректное значение. bindingAdapterPosition учитывает текущее состояние адаптера
| fun bind(chat: Chat) { | ||
| val title = itemView.findViewById<TextView>(R.id.Title) | ||
| val statusIcon = itemView.findViewById<ImageView>(R.id.Delivered) | ||
| val avatarImageView = itemView.findViewById<ImageView>(R.id.Avatar) |
There was a problem hiding this comment.
Каждый раз вызывается findViewById для поиска title, statusIcon и avatarImageView, хотя часть View уже найдена в конструкторе. Это неэффективно при прокрутке списка.
Вынесите поиск всех View (title, statusIcon, avatarImageView) в конструктор ChatViewHolder и сохраните их как поля класса. В bind() просто используйте уже найденные ссылки. Это стандартная практика оптимизации ViewHolder в RecyclerView.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.