Homework_10 implementation(RecyclerView)#58
Open
Vp-Ma wants to merge 1 commit intoAndroid-Developer-Basic:masterfrom
Open
Homework_10 implementation(RecyclerView)#58Vp-Ma wants to merge 1 commit intoAndroid-Developer-Basic:masterfrom
Vp-Ma wants to merge 1 commit intoAndroid-Developer-Basic:masterfrom
Conversation
| private var ChatItemList = mutableListOf<ChatTlgItem>() | ||
| fun setList(list: List<ChatTlgItem>) { | ||
| ChatItemList = list.toList() as MutableList<ChatTlgItem> | ||
| notifyDataSetChanged() |
There was a problem hiding this comment.
При каждом обновлении списка перерисовываются все элементы через notifyDataSetChanged. Если будем использовать ListAdapter с DiffUtil.ItemCallback, то обновит только измененные элементы и улучшит производительность.
| direction: Int | ||
| ) { | ||
| val itemPosition:Int = viewHolder.adapterPosition | ||
| adapter.onItemSwipe( itemPosition, direction ) |
There was a problem hiding this comment.
Если добавить проверку позиции перед использованием, будет безопаснее при быстрых свайпах
| if (!recyclerView.canScrollVertically(1)) { | ||
| var chatAddList = ChatTlgService( false ) | ||
| ChatTlgList = ChatTlgList + chatAddList.getTlgChat() | ||
| chatTlgAdapter.setList( ChatTlgList ) |
There was a problem hiding this comment.
При достижении конца списка onScrolled может вызываться несколько раз подряд. Флаг isLoading для защиты от повторных вызовов будет хорошо смотреться
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.