Skip to content

sprint 4#1

Open
AngryNiko wants to merge 2 commits intomainfrom
develop
Open

sprint 4#1
AngryNiko wants to merge 2 commits intomainfrom
develop

Conversation

@AngryNiko
Copy link
Owner

basic tests

@Test
public void checkQuestionsAndAnswersChrome() throws InterruptedException {
driver = new ChromeDriver();
driver.get("https://qa-scooter.praktikum-services.ru/");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно улучшить: урл хранить в константах

orderPage.fillSecondForm(date, rentPeriod, black, grey);
}

@After

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

можно улучшить: действие нужно для каждого теста, лучше вынести на уровень выше

private final WebDriver driver;
private final WebDriverWait wait;

public static final String URL = "https://qa-scooter.praktikum-services.ru/";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно улучшить: константы лучше хранить в отдельном классе, урл не является частью страницы

driver = new FirefoxDriver();
}

driver.get("https://qa-scooter.praktikum-services.ru/");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Нужно исправить: у тебя есть переменная с этим значением

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants