[BUILD-1010] feat: Preserve custom CSS on AnkiHub note types#1088
Merged
RisingOrange merged 9 commits intomainfrom Jan 29, 2025
Merged
[BUILD-1010] feat: Preserve custom CSS on AnkiHub note types#1088RisingOrange merged 9 commits intomainfrom
RisingOrange merged 9 commits intomainfrom
Conversation
be2b7bc to
d0a538d
Compare
2 tasks
abdnh
approved these changes
Jan 29, 2025
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are preserving HTML below the ankihub end comment on the note type card templates, but we don't have that for the note type styling.
This task makes it so that content below a special ankihub end comment is preserved for the note type styling.
It also fixes an issue where more and more white space is added to the note type templates.
Related PR for the AnKing note types add-on: AnKing-VIP/anking_notes_addon#34
Related issues
AnKing-VIP/AnKing-Note-Types#219 (comment)
Proposed changes
note_type_with_updated_templatesfunction (fromankihub.main.utils.py) tonote_type_with_updated_templates_and_cssnote_type_with_updated_templates_and_csswhen updating note typesentry_point._adjust_ankihub_note_type_templates)How to reproduce
It's the same behavior for the other tabs besides Styling (Front Template and Back Template), which we already had previously