Skip to content

Test: Support multiple threads writing to subprocess_results.log #1877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
heifner wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Test: Support multiple threads writing to subprocess_results.log #1877

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6c36a0
Support multiple threads writing to subprocess_results.log
heifner Dec 4, 2025
f482401
Hold lock for Utils.checkOutputFilename access
heifner Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 19 additions & 15 deletions tests/TestHarness/testUtils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
import shutil
import sys
from pathlib import Path
import threading

###########################################################################################

Expand Down Expand Up @@ -82,6 +83,8 @@ class Utils:
ConfigDir=f"{DataPath}/"

TimeFmt='%Y-%m-%dT%H:%M:%S.%f'
# lock to serialize writes to subprocess_results.log across threads
_check_output_lock = threading.Lock()

@staticmethod
def timestamp():
Expand All @@ -90,21 +93,22 @@ def timestamp():
@staticmethod
def checkOutputFileWrite(time, cmd, output, error):
stop=Utils.timestamp()
os.makedirs(Utils.TestLogRoot, exist_ok=True)
os.makedirs(Utils.DataPath, exist_ok=True)
if not hasattr(Utils, "checkOutputFile"):
Utils.checkOutputFilename=f"{Utils.DataPath}/subprocess_results.log"
if Utils.Debug: Utils.Print("opening %s in dir: %s" % (Utils.checkOutputFilename, os.getcwd()))
Utils.checkOutputFile=open(Utils.checkOutputFilename,"w")
else:
Utils.checkOutputFile=open(Utils.checkOutputFilename,"a")

Utils.checkOutputFile.write(Utils.FileDivider + "\n")
Utils.checkOutputFile.write("start={%s}\n" % (time))
Utils.checkOutputFile.write("cmd={%s}\n" % (" ".join(cmd)))
Utils.checkOutputFile.write("cout={%s}\n" % (output))
Utils.checkOutputFile.write("cerr={%s}\n" % (error))
Utils.checkOutputFile.write("stop={%s}\n" % (stop))
# Serialize concurrent writes and open file per write to avoid sharing closed handles
with Utils._check_output_lock:
os.makedirs(Utils.TestLogRoot, exist_ok=True)
os.makedirs(Utils.DataPath, exist_ok=True)

# Ensure filename is set
if not hasattr(Utils, "checkOutputFilename"):
Utils.checkOutputFilename=f"{Utils.DataPath}/subprocess_results.log"

with open(Utils.checkOutputFilename, "a") as f:
f.write(Utils.FileDivider + "\n")
f.write("start={%s}\n" % (time))
f.write("cmd={%s}\n" % (" ".join(cmd)))
f.write("cout={%s}\n" % (output))
f.write("cerr={%s}\n" % (error))
f.write("stop={%s}\n" % (stop))

@staticmethod
def Print(*args, **kwargs):
Expand Down
Loading