Open
Conversation
nodchip
reviewed
Dec 3, 2025
| } | ||
|
|
||
| private: | ||
| std::string NormalizeEmail(const std::string& email) const { |
There was a problem hiding this comment.
Normalize という単語は、項目内部での冗長性の削減を表すようです。一方、 Canonicalize という単語は、項目間の比較のために変化させることを表すようです。今回の場合は Canonicalize のほうを使うのが適していると思います。
| std::string NormalizeEmail(const std::string& email) const { | ||
| std::size_t at_position = email.find('@'); | ||
| std::string local = email.substr(0, at_position); | ||
| std::string domain = email.substr(at_position); |
There was a problem hiding this comment.
ドメインパートは @ の次の文字から始まるため、変数名と格納される値がややずれているように思いました。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This: https://leetcode.com/problems/unique-email-addresses/description/
Next: https://leetcode.com/problems/first-unique-character-in-a-string/description/