Create 387. First Unique Character in a String#27
Open
Apo-Matchbox wants to merge 2 commits intomainfrom
Open
Conversation
t9a-dev
reviewed
Dec 5, 2025
nodchip
reviewed
Dec 5, 2025
| for (char c : s) { | ||
| frequency[c - 'a']++; | ||
| } | ||
| for (int i = 0; i < static_cast<int>(s.size()); ++i) { |
There was a problem hiding this comment.
ちゃんと int に static_cast していて、えらいなと思いました。
Co-authored-by: t9a-dev <t9a.dev@icloud.com>
Apo-Matchbox
commented
Dec 5, 2025
| public: | ||
| int firstUniqChar(const std::string& s) { | ||
| std::vector<int> frequency(26, 0); | ||
| std::array<int, 26> frequency{}; |
Owner
Author
There was a problem hiding this comment.
ありがとうございます！
ご指摘の通りだと思いました！要素数が変わらない場面では固定長配列を選ぶ、という視点は今まであまり意識していなかったので勉強になりました。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This: https://leetcode.com/problems/first-unique-character-in-a-string/description/
Next: https://leetcode.com/problems/subarray-sum-equals-k/description/