Skip to content

Address UBSAN messages reported by kernel #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
foxcob wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Address UBSAN messages reported by kernel #41

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4505a5
Address UBSAN messages reported by kernel like the following:
foxcob Jun 30, 2022
fb7fe1e
Fix indenting and use tabs.
foxcob Jun 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions aq_nic.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,8 +326,10 @@ static void aq_nic_polling_timer_cb(struct timer_list *t)
unsigned int i = 0U;

for (i = 0U, aq_vec = self->aq_vec[0];
self->aq_vecs > i; ++i, aq_vec = self->aq_vec[i])
aq_vec_isr(i, (void *)aq_vec);
self->aq_vecs > i; ++i) {
aq_vec = self->aq_vec[i];
aq_vec_isr(i, (void *) aq_vec);
}

mod_timer(&self->polling_timer, jiffies +
AQ_CFG_POLLING_TIMER_INTERVAL);
Expand Down Expand Up @@ -589,7 +591,8 @@ int aq_nic_start(struct aq_nic_s *self)
goto err_exit;

for (i = 0U, aq_vec = self->aq_vec[0];
self->aq_vecs > i; ++i, aq_vec = self->aq_vec[i]) {
self->aq_vecs > i; ++i) {
aq_vec = self->aq_vec[i];
err = aq_vec_start(aq_vec);
if (err < 0)
goto err_exit;
Expand Down Expand Up @@ -649,7 +652,8 @@ int aq_nic_start(struct aq_nic_s *self)
AQ_CFG_POLLING_TIMER_INTERVAL);
} else {
for (i = 0U, aq_vec = self->aq_vec[0];
self->aq_vecs > i; ++i, aq_vec = self->aq_vec[i]) {
self->aq_vecs > i; ++i) {
aq_vec = self->aq_vec[i];
err = aq_pci_func_alloc_irq(self, i, self->ndev->name,
aq_vec_isr, aq_vec,
aq_vec_get_affinity_mask(aq_vec));
Expand Down Expand Up @@ -1084,8 +1088,8 @@ u64 *aq_nic_get_stats(struct aq_nic_s *self, u64 *data)

for (tc = 0U; tc < self->aq_nic_cfg.tcs; tc++) {
for (i = 0U, aq_vec = self->aq_vec[0];
aq_vec && self->aq_vecs > i;
++i, aq_vec = self->aq_vec[i]) {
aq_vec && self->aq_vecs > i; ++i) {
aq_vec = self->aq_vec[i];
data += count;
count = aq_vec_get_sw_stats(aq_vec, tc, data);
}
Expand Down Expand Up @@ -1567,8 +1571,10 @@ int aq_nic_stop(struct aq_nic_s *self)
aq_ptp_irq_free(self);

for (i = 0U, aq_vec = self->aq_vec[0];
self->aq_vecs > i; ++i, aq_vec = self->aq_vec[i])
self->aq_vecs > i; ++i) {
aq_vec = self->aq_vec[i];
aq_vec_stop(aq_vec);
}

aq_ptp_ring_stop(self);

Expand Down