Zoo grazing n and p units#76
Open
MichaelBarryBMT wants to merge 1 commit intoAquaticEcoDynamics:masterfrom
Open
Zoo grazing n and p units#76MichaelBarryBMT wants to merge 1 commit intoAquaticEcoDynamics:masterfrom
MichaelBarryBMT wants to merge 1 commit intoAquaticEcoDynamics:masterfrom
Conversation
Suggested removal of mg to mm conversion in one case of calculation of grazing_n (and grazing_p)
Contributor
|
Hi MEB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested removal of mg to mm conversion in one case of calculation of grazing_n (and grazing_p). This is via removal of /14.0 (and /31.0 for P) conversion - this converts from mm to mg, but not sure why this is needed in the calculations (and is inconsistent with other calculations) as all quantities are mm? These factors will reduce the required grazing_n (and grazing_p) rates by > 1 OOM.
The time dimension is listed /d in the code - acknowledged it may be /s, but the potential issue above remains.