feat: UpgradeAndEnableFastConfirmAction action#305
Draft
Conversation
godzillaba
reviewed
Aug 7, 2024
src/gov-action-contracts/AIPs/EnableFastConfirm/UpgradeAndEnableFastConfirmAction.sol
Outdated
Show resolved
Hide resolved
godzillaba
approved these changes
Aug 7, 2024
gzeoneth
commented
Aug 8, 2024
src/gov-action-contracts/AIPs/EnableFastConfirm/NovaUpgradeAndEnableFastConfirmAction.sol
Outdated
Show resolved
Hide resolved
Collaborator
|
verified bytecode of rollup logics |
godzillaba
requested changes
Aug 9, 2024
Comment on lines
+13
to
+14
| 0x0000000000000000000000000000000000000000, // TODO: anyTrustFastConfirmer | ||
| 1 // TODO: newMinimumAssertionPeriod in blocks |
Collaborator
There was a problem hiding this comment.
i know we're in draft right now and these are marked with comments but just adding a blocking review so we definitely don't forget to set these
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.