Draft
Conversation
gzeoneth
requested changes
Oct 17, 2024
| address public immutable newUpgradeExecutorImplementation = address(new UpgradeExecutor()); | ||
|
|
||
| function perform() external { | ||
| _upgradeTo(newUpgradeExecutorImplementation); |
Collaborator
There was a problem hiding this comment.
not a big fan of using ERC1967Upgrade to modify the storage slot directly, can we just have it go through the proxy admin instead?
Collaborator
Author
There was a problem hiding this comment.
yeah we can do that, i have a couple versions at earlier commits that do
eg d74a6d9#diff-96112336c8e4f94e4f509a6e67874a61d2637890f110f1b10e95998a50996812
eg2 (gets proxy admin at perform time) 90fb0bc#diff-96112336c8e4f94e4f509a6e67874a61d2637890f110f1b10e95998a50996812
Collaborator
Author
There was a problem hiding this comment.
reverted back to the first example
src/gov-action-contracts/AIPs/SecurityCouncilMgmt/GovernanceChainSCMgmtActivationAction.sol
Outdated
Show resolved
Hide resolved
gzeoneth
reviewed
Oct 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
should merge #317 first
51db9a3 removes the
UpgradeExecutorsource and tests from this repo and replaces it with the@offchainlabs/upgrade-executornpm package. A lot of files needed small changes to buildthe other commits are the upgrade action and tests