Open
Conversation
This reverts commit ace5bab.
* use DVP in governor * remove relic of dvp estimation in quorum calc * Revert "remove relic of dvp estimation in quorum calc" This reverts commit 3af8bce. * keep old quorum behavior when checkpoint is old * add quorum clamping * document quorum jumping on admin function * comment * test governor dvp * update sigs and storage * fix test * add comment * snapshot
* use DVP in governor * first action * second action * fmt * comment * single action * remove relic of dvp estimation in quorum calc * Revert "remove relic of dvp estimation in quorum calc" This reverts commit 3af8bce. * Revert "single action" This reverts commit a132247. * keep old quorum behavior when checkpoint is old * add quorum clamping * set min/max quorum in action * document quorum jumping on admin function * comment * test governor dvp * fix rename functions * update sigs and storage * update sigs and storage * fix test * add prop1 test, use relay * remove second action * format * add comment * snapshot * fix test path * snapshot * update sigs and storage * undo toml change * Update src/gov-action-contracts/AIPs/TotalDvpQuorum/ActivateDvpQuorumAction.sol Co-authored-by: José FP <105675159+TucksonDev@users.noreply.github.com> --------- Co-authored-by: José FP <105675159+TucksonDev@users.noreply.github.com>
* Add V2 governor and basic testing, scripts for use later * Store proposers and revert cancel if not proposer * Add governor action contract, upgrade script, and tests * Add `MultiProxyUpgradeAction` contract and upgrade through proxy * Make fns virtual, mapping internal, and add natspec in GovernorV2 * Fix nits and separate test helper from deployConstants * Fix nits * Update naming in gov upgrade action contract * Fix nits and update constants * Update src/L2ArbitrumGovernorV2.sol --------- Co-authored-by: Ed Mazurek <Edward.R.Mazurek@gmail.com>
* Add propose, queue, and execute tests * Add `vm.assume`s in test
Co-authored-by: Ed Mazurek <Edward.R.Mazurek@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
combining #364 and #365
Deployment
L2ArbitrumToken: https://arbiscan.io/address/0x6462989b105a80b5301a6f65a79e1e5dfee7c1b9
L2ArbitrumGovernor: https://arbiscan.io/address/0x44ff126fc78d58e44efa2d8f6e45d86bb5bb9c00
ActivateDvpQuorumAction: https://arbiscan.io/address/0x19C8Ea5F8288abF138D72a13344E699a7A71400c
Params
Payload