checkpoint min max quorum settings#371
Open
godzillaba wants to merge 23 commits intodvp-and-cancelfrom
Open
Conversation
…ax-quorum-settings
godzillaba
commented
Jan 23, 2026
src/L2ArbitrumGovernor.sol
Outdated
Comment on lines
239
to
241
| if (_maximumQuorumHistory.latest() == 0) { | ||
| return calculatedQuorum; | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
what is this check supposed to do? if there's no min or max set the whole thing reverts when dvpQuorumStartBlock is called at the top
Collaborator
Author
There was a problem hiding this comment.
since the code assumes that some min and max are set in the upgrade
gzeoneth
requested changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.