Core: typing and cleaning in SNIClient #5649
Open
+52
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
beauxq
commented
Nov 17, 2025
Comment on lines
-350
to
+369
| Operands: typing.List[str] | ||
| # TODO: When Python 3.11 is the lowest version supported, `Operands` can use `typing.NotRequired` (pep-0655) | ||
| # Then the `Operands` key doesn't need to be given for opcodes that don't use it. | ||
| Operands: list[str] |
Collaborator
Author
There was a problem hiding this comment.
I thought about doing what was in this TODO comment (that I wrote a long time ago).
But then I figured it would be safer, and easier, and more consistent to just include the Operands key even if it's not necessary.
The only downside is sending a few extra bytes to SNI, only when we make the initial connection.
Contributor
There was a problem hiding this comment.
Any reason not to make it optional a-la | None instead?
Collaborator
Author
There was a problem hiding this comment.
That seems to me like a worse version of the same downside. (null is more bytes than [])
But then it also adds another possible downside as something that hasn't gone through years of testing already.
NewSoupVi
added
the
is: refactor/cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
mostly just updating the typing
How was this tested?
generated and connected to a snes game and picked up a few items