WebHost/MultiServer: Default to localhost for hostname and show in yaml description #5707
+20
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: core
duckboycool
commented
Dec 1, 2025
| player_name = options["name"] | ||
| del options["name"] | ||
|
|
||
| description = (f"Generated by {'https' if request.is_secure else 'http'}://{app.config['HOST_ADDRESS']} " |
Contributor
Author
There was a problem hiding this comment.
Not sure if this is the best way to determine if the server is https or not. We could also use request.host_url and go off of the request for hostname too, but I don't think that'd be desirable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Changes the default hostname to
localhostfor both--hostandHOST_ADDRESS, and adds the specific address (and version) in the descriptions for WebHost-generated YAMLs. If somebody prefers to be doxxed, they can manually set an empty string to use the current behavior.Some discussion in the discord below here. https://discord.com/channels/731205301247803413/731214280439103580/1443405760699826387
How was this tested?
Generating regular and weighted YAMLs, checking room page and server log to make sure they don't doxx me, generating a new host.yaml to make sure the default works, setting the values back to empty string.
If this makes graphical changes, please attach screenshots.