WebHost: turn Room.timeout from a database column into a flask app config field #5709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: webhost
Contributor
|
As someone that hosts a private instance of AP, I use this property to give separate rooms different timeouts; significantly longer timeouts for running asyncs, near-zero ones for concluded ones to keep them from staying up for long. I would no longer be able to do that after this change, and would thus likely revert this commit if it is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
removes a per room property we haven't used in over 2 years, also optimizes autolauncher since ponyorm can now fully compile the timeout ahead of time
How was this tested?
locally with a mariadb instance. The column still existing does no harm and can be removed later seperately.