Skip to content

Add CI win build with units #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Georacer wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add CI win build with units #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions .github/workflows/win_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
cmake -S plotjuggler -B pj_build -DCMAKE_INSTALL_PREFIX=${{ github.workspace }}\pj_install -DCMAKE_BUILD_TYPE=RelWithDebInfo
cmake --build pj_build --config RelWithDebInfo --target install

- name: Build your plugin
- name: Build the plugin without unit names
run: |
Remove-Item -Recurse -Force build -ErrorAction SilentlyContinue
mkdir build
Expand All @@ -60,5 +60,21 @@ jobs:
- name: Upload plugin artifact
uses: actions/upload-artifact@v4
with:
name: plugin-build
path: build/
name: DataAPBin_no_units
path: build/Release/DataAPBin.dll

- name: Build the plugin with unit names
run: |
Remove-Item -Recurse -Force build -ErrorAction SilentlyContinue
mkdir build
cd build
cmake .. -Dplotjuggler_DIR="${{ github.workspace }}\pj_install\lib\cmake\plotjuggler" -DADD_UNITS=ON
cmake --build . --config Release
cmake --install . --prefix "${{ github.workspace }}\plugin_install"


- name: Upload plugin artifact
uses: actions/upload-artifact@v4
with:
name: DataAPBin_with_units
path: build/Release/DataAPBin.dll
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ This requires that you have Docker installed in your system.
Build arguments include:
- `ADD_UNITS[=OFF]`: Set to `ON` to enable the display of units in the logged fields. Read at the end for more information.
- `BASE_IMAGE[=ubuntu:22.04]`: Specify the OS image to build off of. It is known that using a different OS than your host OS may result in the plugin not working.
- `PJ_TAG[=3.9.2]`: The PlotJuggler git branch or tag to use when cloing and compiling PlotJuggler.
- `PJ_TAG[=3.9.2]`: The PlotJuggler git branch or tag to use when cloning and compiling PlotJuggler.

Once compilation is finished, you will find your `.so` plugin in the `artifacts` folder you created previously.

Expand Down
Loading