Feature: Display hometown and birthplace on employee detail page#78
Draft
google-labs-jules[bot] wants to merge 177 commits intomainfrom
Draft
Feature: Display hometown and birthplace on employee detail page#78google-labs-jules[bot] wants to merge 177 commits intomainfrom
google-labs-jules[bot] wants to merge 177 commits intomainfrom
Conversation
…ebsite into feature/WEB-26
This commit enhances the employee detail page by adding the display of the employee's hometown and birthplace. - The `readUser` call in the employee detail page has been updated to deep-fetch the necessary location data, including system, planet/moon, and landing zone information. - A helper function, `formatLocation`, has been introduced to format the location data into the desired 'System / Planet or Moon / Landing Zone' format. - The data tables (`mainTables` and `sideTables`) have been converted to computed properties to ensure reactivity. This also fixes a latent bug where the tables would not update if the employee data changed. - The 'Persönliche Informationen' table now displays the formatted hometown and birthplace. - A minor bug was fixed where the label for 'Alter' (age) was incorrectly displayed as 'Geschlecht' (gender).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds the hometown and birthplace of an employee to their detail page. The information is displayed in the format 'System / Planet or Moon / Landing Zone'.