Skip to content

Signups refactor #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 17 commits into from
Closed

Signups refactor #29

wants to merge 17 commits into from

Conversation

@3Mydlo3
Copy link
Member

@3Mydlo3 3Mydlo3 commented Jan 6, 2021 •
edited
Loading

When merged this PR will:

  • Remove Web and SharedClasses projects as they server no purpose
  • Use IEmote in Slot instead of string
  • Get rid of static helpers
  • Create helper methods for common tasks (eg. getting user's missions, currently edited)
  • Cleanup and refactor code

Close #42

@3Mydlo3 3Mydlo3 mentioned this pull request Jan 6, 2021
Merged
@3Mydlo3 3Mydlo3 added the enhancement Enhancement to existing feature label Feb 3, 2021
@3Mydlo3 3Mydlo3 mentioned this pull request Feb 3, 2021
Closed
@3Mydlo3
Copy link
Member Author

3Mydlo3 commented Apr 29, 2021

Dumped in favor of #47.

@3Mydlo3 3Mydlo3 closed this Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement Enhancement to existing feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Emotes in signups imported from file not handled properly

2 participants

@3Mydlo3