Signups design

.editorconfig

@@ -0,0 +1,19 @@
+root = true
+
+[*]
+end_of_line = crlf
+insert_final_newline = true
+charset = utf-8
+indent_style = space
+indent_size = 4
+trim_trailing_whitespace = true
+
+[*.md]
+trim_trailing_whitespace = false
+
+[*.csproj]
+indent_size = 2
+
+[*.json]
+indent_size
+= 2

.gitignore

@@ -1,8 +1,8 @@
 .vs/*
 .idea/*
+Logs/*
 */obj/*
 */bin/*
-*/Logs/*
 *.user
 *.dat
 *.mp3

ArmaForces.Boderator.BotService.Tests/ArmaForces.Boderator.BotService.Tests.csproj

@@ -0,0 +1,34 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <TargetFramework>net6.0</TargetFramework>
+    <Nullable>enable</Nullable>
+    <IsPackable>false</IsPackable>
+    <OutputType>Library</OutputType>
+  </PropertyGroup>
+
+  <ItemGroup>
+    <ProjectReference Include="..\ArmaForces.Boderator.BotService\ArmaForces.Boderator.BotService.csproj" />
+    <ProjectReference Include="..\ArmaForces.Boderator.Core.Tests\ArmaForces.Boderator.Core.Tests.csproj" />
+  </ItemGroup>
+
+  <ItemGroup>
+    <PackageReference Include="AutoFixture" Version="4.17.0" />
+    <PackageReference Include="CSharpFunctionalExtensions" Version="2.28.3" />
+    <PackageReference Include="FluentAssertions" Version="6.5.1" />
+    <PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="6.0.3" />
+    <PackageReference Include="Microsoft.AspNetCore.TestHost" Version="6.0.3" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.1.0" />
+    <PackageReference Include="Moq" Version="4.17.2" />
+    <PackageReference Include="xunit" Version="2.4.1" />
+    <PackageReference Include="xunit.runner.visualstudio" Version="2.4.3">
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+      <PrivateAssets>all</PrivateAssets>
+    </PackageReference>
+    <PackageReference Include="coverlet.collector" Version="3.1.2">
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+      <PrivateAssets>all</PrivateAssets>
+    </PackageReference>
+  </ItemGroup>
+
+</Project>

ArmaForces.Boderator.BotService.Tests/Features/Health/HealthControllerTests.cs

@@ -0,0 +1,23 @@
+using System.Threading.Tasks;
+using ArmaForces.Boderator.BotService.Tests.TestUtilities.TestBases;
+using ArmaForces.Boderator.BotService.Tests.TestUtilities.TestFixtures;
+using ArmaForces.Boderator.Core.Tests.TestUtilities;
+using Xunit;
+
+namespace ArmaForces.Boderator.BotService.Tests.Features.Health
+{
+    [Trait("Category", "Integration")]
+    public class HealthControllerTests : ApiTestBase
+    {
+        public HealthControllerTests(TestApiServiceFixture testApi)
+            : base(testApi) { }
+
+        [Fact]
+        public async Task Ping_AllOk_ReturnsPong()
+        {
+            var result = await HttpGetAsync("api/health/ping");
+
+            result.ShouldBeSuccess("pong");
+        }
+    }
+}

ArmaForces.Boderator.BotService.Tests/Features/Missions/CreateMissionsControllerTests.cs

@@ -0,0 +1,97 @@
+using System;
+using System.Collections.Generic;
+using System.Threading.Tasks;
+using ArmaForces.Boderator.BotService.Features.Missions.DTOs;
+using ArmaForces.Boderator.BotService.Tests.TestUtilities.TestBases;
+using ArmaForces.Boderator.BotService.Tests.TestUtilities.TestFixtures;
+using ArmaForces.Boderator.Core.Tests.TestUtilities;
+using Xunit;
+
+namespace ArmaForces.Boderator.BotService.Tests.Features.Missions
+{
+    [Trait("Category", "Integration")]
+    public class MissionsControllerTests : ApiTestBase
+    {
+        public MissionsControllerTests(TestApiServiceFixture testApi)
+            : base(testApi) { }
+
+        [Theory, ClassData(typeof(CreateMissionInvalidRequestTestData)), Trait("Category", "Integration")]
+        public async Task CreateMission_InvalidRequest_ReturnsBadRequest(MissionCreateRequestDto missionCreateRequestDto)
+        {
+            var result = await HttpPostAsync<MissionCreateRequestDto, MissionDto>("api/missions", missionCreateRequestDto);
+
+            result.ShouldBeFailure();
+        }
+
+        [Theory, ClassData(typeof(CreateMissionValidRequestTestData)), Trait("Category", "Integration")]
+        public async Task CreateMission_ValidRequest_MissionCreated(MissionCreateRequestDto missionCreateRequestDto)
+        {
+            var result = await HttpPostAsync<MissionCreateRequestDto, MissionDto>("api/missions", missionCreateRequestDto);
+
+            result.ShouldBeSuccess(missionCreateRequestDto);
+        }
+
+        private class CreateMissionValidRequestTestData : TheoryData<MissionCreateRequestDto>
+        {
+            private readonly MissionCreateRequestDto _minimalRequest = new()
+            {
+                Title = "Test mission title",
+                Owner = "Test mission owner"
+            };
+
+            public CreateMissionValidRequestTestData()
+            {
+                var testCases = new List<MissionCreateRequestDto>
+                {
+                    _minimalRequest,
+                    _minimalRequest with
+                    {
+                        Description = "Test mission description"
+                    },
+                    _minimalRequest with
+                    {
+                        MissionDate = DateTime.Now.AddHours(-1)
+                    },
+                    _minimalRequest with
+                    {
+                        ModsetName = "Test-mission-modset"
+                    },
+                    _minimalRequest with
+                    {
+                        Description = "Test mission description",
+                        MissionDate = DateTime.Now.AddHours(-1),
+                        ModsetName = "Test-mission-modset"
+                    }
+                };
+
+                foreach (var testCase in testCases) Add(testCase);
+            }
+        }
+
+        private class CreateMissionInvalidRequestTestData : TheoryData<MissionCreateRequestDto>
+        {
+            public CreateMissionInvalidRequestTestData()
+            {
+                var testCases = new List<MissionCreateRequestDto>
+                {
+                    new()
+                    {
+                        Title = "Test mission title without owner"
+                    },
+                    new()
+                    {
+                        Owner = "Test mission owner without title"
+                    },
+                    new()
+                    {
+                        Title = "Test mission title",
+                        Owner = "Test mission owner",
+                        ModsetName = "Modset name with whitespace characters"
+                    }
+                };
+
+                foreach (var testCase in testCases) Add(testCase);
+            }
+        }
+    }
+}

ArmaForces.Boderator.BotService.Tests/Features/Missions/GetMissionsControllerTests.cs

@@ -0,0 +1,88 @@
+using System.Collections.Generic;
+using System.Linq;
+using System.Threading.Tasks;
+using ArmaForces.Boderator.BotService.Features.Missions.DTOs;
+using ArmaForces.Boderator.BotService.Tests.TestUtilities.TestBases;
+using ArmaForces.Boderator.BotService.Tests.TestUtilities.TestFixtures;
+using ArmaForces.Boderator.Core.Tests.TestUtilities;
+using AutoFixture;
+using CSharpFunctionalExtensions;
+using FluentAssertions;
+using Xunit;
+
+namespace ArmaForces.Boderator.BotService.Tests.Features.Missions;
+
+[Trait("Category", "Integration")]
+public class GetMissionsControllerTests : ApiTestBase
+{
+    public GetMissionsControllerTests(TestApiServiceFixture testApi)
+        : base(testApi) { }
+
+    [Fact]
+    public async Task GetMission_MissionExists_ReturnsExistingMission()
+    {
+        var missionCreateRequest = new MissionCreateRequestDto
+        {
+            Title = Fixture.Create<string>(),
+            Owner = Fixture.Create<string>(),
+            Description = Fixture.Create<string>()
+        };
+
+        var missionCreateResult = await HttpPostAsync<MissionCreateRequestDto, MissionDto>("api/missions", missionCreateRequest);
+
+        var expectedMission = new MissionDto
+        {
+            Title = missionCreateResult.Value.Title,
+            Description = missionCreateRequest.Description,
+            Owner = missionCreateRequest.Owner,
+            MissionDate = missionCreateResult.Value.MissionDate,
+            MissionId = missionCreateResult.Value.MissionId
+        };
+
+        var result = await HttpGetAsync<MissionDto>($"api/missions/{expectedMission.MissionId}");
+
+        result.ShouldBeSuccess(expectedMission);
+    }    
+
+    [Fact]
+    public async Task GetMissions_SomeMissionsExist_ReturnsAllMissions()
+    {
+        var createdMissions = await CreateSomeMissions(count: 5);
+        var creationResult = createdMissions.Combine();
+        creationResult.ShouldBeSuccess();
+
+        var expectedMissions = creationResult.Value
+            .Select(x => new MissionDto
+            {
+                Title = x.createdMission.Title,
+                Description = x.createdMission.Description,
+                Owner = x.createdMission.Owner,
+                MissionDate = x.createdMission.MissionDate,
+                MissionId = x.createdMission.MissionId
+            })
+            .ToList();
+
+        var result = await HttpGetAsync<List<MissionDto>>($"api/missions");
+
+        result.ShouldBeSuccess(x => x.Should().Contain(expectedMissions));
+    }
+
+    private async Task<List<Result<(MissionDto createdMission, MissionCreateRequestDto createRequest)>>> CreateSomeMissions(int count = 1)
+    {
+        return await AsyncEnumerable.Range(0, count)
+            .Select(x => new MissionCreateRequestDto
+            {
+                Title = Fixture.Create<string>(),
+                Owner = Fixture.Create<string>(),
+                Description = Fixture.Create<string>()
+            })
+            .SelectAwait(async createRequest => {
+                var createResult = await HttpPostAsync<MissionCreateRequestDto, MissionDto>("api/missions", createRequest);
+                return (createResult, createRequest);
+            })
+            .Select(x => x.createResult.IsSuccess
+                ? Result.Success((x.createResult.Value, x.createRequest))
+                : x.createResult.ConvertFailure<(MissionDto, MissionCreateRequestDto)>())
+            .ToListAsync();
+    }
+}

ArmaForces.Boderator.BotService.Tests/Features/Missions/SignupsControllerTests.cs

@@ -0,0 +1,58 @@
+using System.Collections.Generic;
+using System.Threading.Tasks;
+using ArmaForces.Boderator.BotService.Features.Missions.DTOs;
+using ArmaForces.Boderator.BotService.Tests.TestUtilities.TestBases;
+using ArmaForces.Boderator.BotService.Tests.TestUtilities.TestFixtures;
+using ArmaForces.Boderator.Core.Tests.TestUtilities;
+using Xunit;
+
+namespace ArmaForces.Boderator.BotService.Tests.Features.Missions
+{
+    public class SignupsControllerTests : ApiTestBase
+    {
+        public SignupsControllerTests(TestApiServiceFixture testApi)
+            : base(testApi) { }
+
+        [Theory, ClassData(typeof(CreateSignupsInvalidRequestTestData)), Trait("Category", "Integration")]
+        public async Task CreateSignups_InvalidRequest_ReturnsBadRequest(
+            SignupsCreateRequestDto signupsCreateRequestDto)
+        {
+            var result =
+                await HttpPostAsync<SignupsCreateRequestDto, SignupsDto>("api/signups", signupsCreateRequestDto);
+
+            result.ShouldBeFailure();
+        }
+
+        private class CreateSignupsInvalidRequestTestData : TheoryData<SignupsCreateRequestDto>
+        {
+            public CreateSignupsInvalidRequestTestData()
+            {
+                var testCases = new List<SignupsCreateRequestDto>
+                {
+                    new()
+                    {
+                        Teams = new List<TeamDto>()
+                    },
+                    new()
+                    {
+                        Mission = new MissionCreateRequestDto(),
+                        Teams = new List<TeamDto>()
+                    },
+                    new()
+                    {
+                        MissionId = 0,
+                        Teams = new List<TeamDto>()
+                    },
+                    new()
+                    {
+                        MissionId = 0,
+                        Mission = new MissionCreateRequestDto(),
+                        Teams = new List<TeamDto>()
+                    }
+                };
+
+                foreach (var testCase in testCases) Add(testCase);
+            }
+        }
+    }
+}