New feature for auto assign ranks by the users themselves #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3Mydlo3
reviewed
Apr 26, 2024
3Mydlo3
requested changes
Apr 26, 2024
Member
3Mydlo3
left a comment
3Mydlo3
left a comment
There was a problem hiding this comment.
Some cleanup would be useful as the code is very chaotic.
3Mydlo3
reviewed
May 1, 2024
| return; | ||
| } | ||
|
|
||
| private async Task RemovedReactionToSignUpsChannel(Cacheable<IUserMessage, ulong> message, ISocketMessageChannel channel, SocketReaction reaction, SignupsData signups) |
Member
There was a problem hiding this comment.
I think RemovedReactionToSignUpsChannel is a bad name pattern. Reactions are added to messages in channels, not to channels. I'd suggest renaming such methods to RemovedReactionInSignupsChannel (notice Signups vs SignUps).
3Mydlo3
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title says everything.
New requirements:
When added adding new rank message is similar to creating missions. Example command with multiple ranks in one message below:
AF!ranga Title of message ; Description of message; @rank1 @rank2 ; 😘🤓Bot will create message in pointed channel. When reaction clicked by user rank is added. When clicked again it is removed.