Announcement banner / Expandable Server data sysem #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a file (
data.json) that can be modified during runtime by admins (set in environment variables) that can control few things in Aspine, such as the announcement banner. It 100% works so far (at least on my machine) but however, there are a few issues:process.env['admins']and is formatted as"admins": "[1234567, 1234567]"(This might not be compatible with the ICTS' hosting and may need to be changed)getDatafunctions are defined at two places, might want to merge the two)Currently, I'm hosting it on Replit (check it out here) and the serverdata is requestable via this URL. You can see how I format stuff with the previous link.
(Please note that this is my first ever pull request and I have no clue if I'm doing it correctly)