Open
Conversation
Allow overriding the spectroscopic slit via a slit_name parameter at both the global (params) and per-recipe (YAML) level. The parameter flows through to cmd["!OBS.slit"] in ScopeSim before OpticalTrain creation. The updateHeaders() slit handling now reads the actual slit from the FITS header (HIERARCH ESO INS OPTI3 NAME) instead of being hardcoded to C-38_1. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
We should move towards having all header keywords specified in the IRDB, so people can use ScopeSIM directly. The FITS header keywords were added here as a hack, because "it worked". You should know the IRDB / ScopeSim well enough to add this logic directly there (because we wrote that code just before you got snatched by the manager machine). (Edit: talking to Kieran here. To Shannon: Thanks for stepping in this gap and making ScopeSim useful for the AIT people!) |
…"] , "!OBS.detector_readout_mode" to ScopesimWrapper.py. These can now be Included in the .yaml files as : 'slit_name', 'pupil_transmission' , 'detector_readout_mode'.
…: either open or set by keyword in .yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow overriding the spectroscopic slit via a slit_name parameter at both the global (params) and per-recipe (YAML) level. The parameter flows through to cmd["!OBS.slit"] in ScopeSim before OpticalTrain creation. The updateHeaders() slit handling now reads the actual slit from the FITS header (HIERARCH ESO INS OPTI3 NAME) instead of being hardcoded to C-38_1.
Caveat - not sure if this is the right way to go about it, but it's what Shannon and I found that works now (without fully understanding the code base)