Fix mutable default arguments in constructors and methods #3247
+19
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates Python anti-pattern B006 where mutable objects (
[],{}) used as default parameter values cause shared state across function calls.Changes
Fixed 6 instances across 4 files by replacing mutable defaults with
Noneand initializing inside the function:CommandFilter.__init__()request_llm()(2 parameters)text_chat()chat_messages()andworkflow_run()Pattern Applied
No functional changes - behavior remains identical.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
api.soulter.top/home/REDACTED/work/AstrBot/AstrBot/.venv/bin/python /home/REDACTED/work/AstrBot/AstrBot/.venv/bin/pytest tests/ -v(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.