Skip to content

[WIP] Fix Docker file by removing duplicate installations #3263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
+7 −6
Closed

[WIP] Fix Docker file by removing duplicate installations #3263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3c3f669
Initial plan
Copilot Nov 1, 2025
f49f9ea
Fix Dockerfiles to use modern uv workflow
Copilot Nov 1, 2025
62ffa59
Add pilk, pyffmpeg, and socksio to dependencies
Copilot Nov 1, 2025
2a15332
Update pyproject.toml
LIghtJUNction Nov 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,9 @@ RUN apt-get update && apt-get install -y curl gnupg && \
rm -rf /var/lib/apt/lists/*

RUN python -m pip install uv
RUN uv pip install -r requirements.txt --no-cache-dir --system
RUN uv pip install socksio uv pilk --no-cache-dir --system
RUN uv sync --no-dev --no-cache
Copy link

Copilot AI Nov 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding the --frozen flag to uv sync (i.e., uv sync --no-dev --no-cache --frozen) to ensure reproducible builds. This prevents uv from updating the lock file and ensures the Docker build uses exact dependency versions from the lock file. However, verify that uv.lock is checked into version control before implementing this change.

Suggested change
RUN uv sync --no-dev --no-cache
RUN uv sync --no-dev --no-cache --frozen

Copilot uses AI. Check for mistakes.

EXPOSE 6185
EXPOSE 6186

CMD [ "python", "main.py" ]
CMD [ "uv", "run", "main.py" ]
5 changes: 2 additions & 3 deletions Dockerfile_with_node
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,9 @@ RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.2/install.sh | b
RUN /bin/bash -c ". \"$NVM_DIR/nvm.sh\" && node -v && npm -v"

RUN python -m pip install uv
RUN uv pip install -r requirements.txt --no-cache-dir --system
RUN uv pip install socksio uv pyffmpeg --no-cache-dir --system
RUN uv sync --no-dev --no-cache
Copy link

Copilot AI Nov 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding the --frozen flag to uv sync (i.e., uv sync --no-dev --no-cache --frozen) to ensure reproducible builds. This prevents uv from updating the lock file and ensures the Docker build uses exact dependency versions from the lock file. However, verify that uv.lock is checked into version control before implementing this change.

Suggested change
RUN uv sync --no-dev --no-cache
RUN uv sync --no-dev --no-cache --frozen

Copilot uses AI. Check for mistakes.

EXPOSE 6185
EXPOSE 6186

CMD ["python", "main.py"]
CMD ["uv", "run", "main.py"]
3 changes: 3 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ dependencies = [
"quart>=0.20.0",
"readability-lxml>=0.8.4.1",
"silk-python>=0.2.6",
"pyffmpeg>=2.4.2.1",
"pilk>=0.1.8",
"socksio>=1.0.0",
Copy link

Copilot AI Nov 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code uses httpx library (in astrbot/cli/utils/plugin.py, astrbot/core/provider/sources/azure_tts_source.py, and astrbot/core/provider/sources/fishaudio_tts_api_source.py) but httpx is not declared as a dependency in pyproject.toml. While httpx may be a transitive dependency, it should be explicitly declared since the code directly imports from it. Add httpx to the dependencies list to ensure proper dependency management.

Suggested change
"socksio>=1.0.0",
"socksio>=1.0.0",
"httpx>=0.27.0",

Copilot uses AI. Check for mistakes.
"slack-sdk>=3.35.0",
"sqlalchemy[asyncio]>=2.0.41",
"sqlmodel>=0.0.24",
Expand Down