-
Notifications
You must be signed in to change notification settings - Fork 1.5k
chore: bump next version #432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @Monkiia, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a critical dependency update for the Next.js framework and its associated SWC compiler binaries. The primary motivation is to mitigate potential security risks identified in the older version, ensuring the application leverages the latest stability and security patches. The changes are confined to dependency manifest files, and the author has verified successful build and deployment post-update. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the next package from version 15.3.1 to ^15.3.8 to address potential security issues, which is a good and necessary change.
My review includes a comment on the versioning strategy in package.json.
Additionally, I noticed that eslint-config-next in your devDependencies is still at version 15.3.1. It is highly recommended to keep eslint-config-next in sync with the next package version to avoid potential linting inconsistencies. Please consider updating it to ^15.3.8 as well in this PR.
| "dependencies": { | ||
| "mermaid": "^11.4.1", | ||
| "next": "15.3.1", | ||
| "next": "^15.3.8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version for the next package has been updated from a pinned version (15.3.1) to a caret-ranged version (^15.3.8). While using a caret range is common for receiving non-breaking updates, it can introduce variability between builds. If your project's policy is to pin dependency versions for maximum reproducibility, you should consider pinning this version as well. Please confirm if this change in versioning strategy is intentional.
| "next": "^15.3.8", | |
| "next": "15.3.8", |
next version is too old might have security issues.
see attached railway alert
test:
successfully build and deployed