chore: use stricter linting for builds #358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jorgeantonio21
left a comment
jorgeantonio21
left a comment
There was a problem hiding this comment.
Looking good.
Left a few (nitty) comments.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
maschad
added
documentation
maschad
commented
Jan 29, 2025
Comment on lines
+1
to
+7
| #![allow(clippy::cast_possible_truncation)] | ||
| #![allow(clippy::cast_possible_wrap)] | ||
| #![allow(clippy::cast_precision_loss)] | ||
| #![allow(clippy::missing_docs_in_private_items)] | ||
| #![allow(clippy::doc_markdown)] | ||
| #![allow(clippy::module_name_repetitions)] | ||
| #![allow(clippy::cast_sign_loss)] |
Member
Author
There was a problem hiding this comment.
These will require quite significant changes, the most substantive being related to
#![allow(clippy::cast_sign_loss)]
#![allow(clippy::cast_possible_truncation)]
#![allow(clippy::cast_possible_wrap)]
#![allow(clippy::cast_precision_loss)]I've outlined the issue more in #374
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #359
I've also introduced a
.codecovfile