Skip to content

feat: add manual movement start toggle on systems#922

Open
galshacham wants to merge 1 commit intoAudiveris:developmentfrom
galshacham:feat/manual-movement-start
Open

feat: add manual movement start toggle on systems#922
galshacham wants to merge 1 commit intoAudiveris:developmentfrom
galshacham:feat/manual-movement-start

Conversation

@galshacham
Copy link
Copy Markdown

@galshacham galshacham commented Mar 24, 2026

Adds a right-click menu action on systems to manually mark/unmark a system as a movement start, independent of automatic indentation detection. This is useful for exercise books and anthologies where multiple pieces share a page without visual indentation.

Changes:

  • New SystemIndentTask for undo/redo support
  • New toggleIndentation method in InterController
  • New rebuildPages method in SystemManager
  • "Mark/Unmark as movement start" action in System context menu

After

Being able to separate scores manually and not only with indentations
image

Tested locally

  • toggled several systems as new movment and rebuilt scores -> allowed extra exports
  • toggled several systems as not movments and rebuilt scores -> returned to original state

This code was written mainly by claude,
I wanted this for something and thought it might come handy as a good feature

Adds a right-click menu action on systems to manually mark/unmark
a system as a movement start, independent of automatic indentation
detection. This is useful for exercise books and anthologies where
multiple pieces share a page without visual indentation.

Changes:
- New SystemIndentTask for undo/redo support
- New toggleIndentation method in InterController
- New rebuildPages method in SystemManager
- "Mark/Unmark as movement start" action in System context menu

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@galshacham galshacham force-pushed the feat/manual-movement-start branch from 2eb36da to a182e62 Compare March 24, 2026 22:37
@galshacham galshacham marked this pull request as ready for review March 24, 2026 22:39
@hbitteur
Copy link
Copy Markdown
Contributor

@galshacham

Thank you for this PR and congratulations on your understanding of the Audiveris code! (even though Claude was involved…)

My only concern is that you created this PR on the "master" branch, whereas we only develop on the "development" branch (or any temporary sub-branch of "development").

Indeed, we try to use the "master" branch only for releases (and we merge "development" into "master" specifically for releases).

Could you redirect your PR to the Audiveris "development" branch?
(Sorry, I'm not very familiar with this procedure, so I can't tell you if it's easy to do.)

Otherwise, I'll first try merging your PR into one of my local "development" branches so I can test everything locally.

Please keep me updated.

@hbitteur
Copy link
Copy Markdown
Contributor

@galshacham
I'm currently testing your PR locally.
I noticed that the Score menu item is not correctly updated in the popup menu, after a system has been marked as a new movement start
I'm debugging
Stay tuned

@galshacham galshacham changed the base branch from master to development March 30, 2026 13:56
@galshacham
Copy link
Copy Markdown
Author

My only concern is that you created this PR on the "master" branch, whereas we only develop on the "development" branch (or any temporary sub-branch of "development").

Done, mb! thanks for notifing.

I noticed that the Score menu item is not correctly updated in the popup menu, after a system has been marked as a new movement start

As far as I understood the workflow of Audiveris, its part of the routine of "recreating scroes" in "Book" tab.
image

Indeed after Rebuilding scores, the score numbers are updated at the right click toggle bar.
image

However, I believe its possible to auto update it once clicking, though it might affect performance a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants