Trevor.Lujan.Advanced1#12
Trevor.Lujan.Advanced1#12trevorlujan123 wants to merge 11 commits intoAustinCodingAcademy:masterfrom
Conversation
|
Really nice work Trevor, I pulled it down and everything looks great. Nice work on the highlighter and the use of stateless functional components. |
| return ( | ||
| <Action | ||
| key={action._id} | ||
| action={action} |
There was a problem hiding this comment.
Inside of Action.js you're trying to access the actionMessage property of action, so make sure you're actually passing in an object. I think right now you're passing a string value.
ivome
left a comment
ivome
left a comment
There was a problem hiding this comment.
Great job!! Clean code, nice functionality, keep it up!!
|
|
||
| .unselect-button, .select-button{ | ||
| background-color: #005eff; | ||
| } |
There was a problem hiding this comment.
Styles would be better placed in the css files for the corresponding component.
| @@ -0,0 +1,17 @@ | |||
| import React, {PropTypes} from 'react'; | |||
|
|
|||
| const Action = props => { | |||
There was a problem hiding this comment.
I would be careful with the naming here. Action usually refers to an actual action. So maybe ActionHistoryListItem would be more descriptive.
3 participants
No description provided.